TPT-4285: Implement integration tests for ReservedIP for IPv4 by mawilk90 · Pull Request #688 · linode/linode_api4-python

mawilk90 · 2026-04-27T12:11:05Z

📝 Description

Integration tests for Reserved IPs

Required tags:
can_reserve_ip
reserved_ips_beta
reserved_ip_nodebalancer

✔️ How to Test

make test-int TEST_ARGS="-k reserved_ip -v"
make test-int TEST_ARGS="-k reserve_ephemeral -v"

Copilot

Pull request overview

This PR expands the integration test suite for the SDK's Reserved IPv4 support, covering the new networking APIs plus cross-resource flows where reserved addresses can be tagged or attached to Linodes and NodeBalancers. It fits into the codebase by adding end-to-end coverage around the Reserved IP models and helpers that were recently added to the client, and it is explicitly stacked on top of linked PR #687.

Changes:

Adds shared integration fixtures for creating reserved IPs and reserved IPs assigned to a Linode.
Adds networking integration tests for reserved IP create/update/assign/allocate/type-conversion flows.
Adds cross-resource reserved IP coverage for tags, NodeBalancers, Linode allocation, and interface-based instance creation.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`test/integration/conftest.py`	Adds reusable fixtures for creating standalone and assigned Reserved IPv4 addresses.
`test/integration/models/networking/test_networking.py`	Adds the main Reserved IPv4 integration coverage and shared assertion helpers.
`test/integration/models/nodebalancer/test_nodebalancer.py`	Adds NodeBalancer creation coverage using a reserved IPv4 address.
`test/integration/models/linode/test_linode.py`	Adds coverage for attaching an existing reserved IPv4 to a Linode.
`test/integration/models/linode/interfaces/test_interfaces.py`	Adds reserved IPv4 coverage for both legacy and Linode interface-generation instance creates.
`test/integration/models/tag/test_tag.py`	Adds tag retrieval coverage for reserved IPv4 tagged objects.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…e#695) Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4 to 5. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@v4...v5) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ode#672)

# Conflicts: # conftest.py # linode_api4/groups/networking.py # linode_api4/groups/tag.py # linode_api4/objects/networking.py # test/unit/groups/networking_test.py

…lement-integration-tests-for-reserved-ip-for-ipv4

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.

+    endpoint = client.base_url + "/networking/reserved/ips/types"
+    types = requests.get(endpoint).json()[
+        "data"
+    ]  # Pricing should be publicly available
+
+    assert isinstance(types, list)
+    assert types[0]["id"] == "reserved-ipv4"
+    assert types[0]["label"] == "Reserved IPv4"
+    assert "hourly" in types[0]["price"]
+    assert "monthly" in types[0]["price"]
+    assert any(price != 0 for price in list(types[0]["price"].values()))
+    assert isinstance(types[0]["region_prices"], list)
+
+


+def create_reserved_ip_assigned(test_linode_client, create_linode):
+    client = test_linode_client
+    linode = create_linode
+    reserved_ip = client.networking.reserved_ip_create(
+        region=linode.region,
+        tags=["test", "assigned"],
+    )
+
+    client.networking.ip_addresses_assign(
+        assignments=[{"address": reserved_ip.address, "linode_id": linode.id}],


+
+    if region:
+        reserved_ip = client.networking.ip_allocate(
+            reserved=reserved, region=TEST_REGION
+        )
+        verify_reserved_ip(reserved_ip)
+    else:
+        reserved_ip = client.networking.ip_allocate(
+            reserved=reserved, linode=linode.id
+        )
+        verify_reserved_ip_assigned(reserved_ip, linode)
+
+    assert reserved_ip.tags == []
+
+    # clean-up
+    reserved_ip = client.load(ReservedIPAddress, reserved_ip.address)
+    reserved_ip.delete()


+    nb = client.nodebalancer_create(
+        region=reserved_ip.region,
+        label=label,
+        firewall=e2e_test_firewall.id,
+        client_udp_sess_throttle=5,
+        ipv4=reserved_ip.address,
+    )


+        ipv4=reserved_ip.address,
+    )
+
+    assert TEST_REGION, nb.region


+    tag, reserved_ip = create_tag_with_reserved_ip
+    tag = test_linode_client.load(Tag, tag.id).objects[0]
+
+    assert vars(tag).keys() == vars(reserved_ip).keys()


+        assignments=[{"address": reserved_ip.address, "linode_id": linode.id}],
+        region=linode.region,
+    )
+


+        linode, _ = client.linode.instance_create(
+            "g6-nanode-1",
+            reserved_ip.region,
+            image="linode/debian12",
+            label=label,
+            interface_generation=iface_type,
+            interfaces=[interface],
+        )


psnoch-akamai · 2026-05-21T11:15:13Z

+    reserved_ip = create_reserved_ip
+    label = get_test_label(length=8)
+
+    if iface_type == InterfaceGeneration.LEGACY_CONFIG:


I don't like this "if" based on iface_type. I wonder if you could extract linode_create_with_LEGACY_CONFIG and linode_create_with_standard_interface function. Then put it as parameter here without "if" statement.
The second idea is to just create 2 separate tests.

How about that?

psnoch-akamai · 2026-05-21T11:19:45Z

+    request.addfinalizer(reserved_ip.delete)
+
+    verify_reserved_ip(reserved_ip)
+    assert reserved_ip.tags == tags if tags else reserved_ip.tags == []


Could you remove that "if" conditional and maybe use 3rd parameter?

Suggested change

assert reserved_ip.tags == tags if tags else reserved_ip.tags == []

assert reserved_ip.tags == expected_tags

psnoch-akamai · 2026-05-21T11:29:34Z

+    client = test_linode_client
+    linode = create_linode
+
+    if region:


In my opinion, there would be two tests to make it easier to read and verify results quickly. The second approach would be to put function name as parameter but I'm not sure if it's possible here

mawilk90 added new-feature for new features in the changelog. testing for updates to the testing suite in the changelog. labels Apr 27, 2026

github-advanced-security AI found potential problems Apr 27, 2026

View reviewed changes

Comment thread test/integration/models/networking/test_networking.py Fixed

mawilk90 added the do-not-merge PRs that should not be merged until the commented issue is resolved label Apr 28, 2026

mawilk90 marked this pull request as ready for review May 4, 2026 07:59

mawilk90 requested a review from a team as a code owner May 4, 2026 07:59

mawilk90 requested review from a team, Copilot, dawiddzhafarov and mgwoj and removed request for a team May 4, 2026 07:59

Copilot started reviewing on behalf of mawilk90 May 4, 2026 08:00 View session

mawilk90 requested review from a team and zliang-akamai and removed request for a team and dawiddzhafarov May 4, 2026 08:00

Copilot AI reviewed May 4, 2026

View reviewed changes

mawilk90 force-pushed the feature/TPT-4285-python-sdk-implement-integration-tests-for-reserved-ip-for-ipv4 branch from b6cff8d to 4b0f363 Compare May 11, 2026 13:22

mawilk90 requested a review from a team as a code owner May 11, 2026 13:22

mawilk90 requested review from ckulinsk and removed request for a team May 11, 2026 13:22

mawilk90 changed the title ~~TPS-4285: Implement integration tests for ReservedIP for IPv4~~ TPT-4285: Implement integration tests for ReservedIP for IPv4 May 11, 2026

dependabot Bot and others added 2 commits May 12, 2026 09:13

Change assignments type from dict to list (linode#687)

8985109

mawilk90 removed the do-not-merge PRs that should not be merged until the commented issue is resolved label May 12, 2026

mgwoj and others added 4 commits May 12, 2026 15:15

TPT-4278: python-sdk: Implement support for Reserved IP for IPv4 (lin…

2f35543

…ode#672)

TPT-4278 python-sdk: Implement support for Reserved IP for IPv4

8a07407

# Conflicts: # conftest.py # linode_api4/groups/networking.py # linode_api4/groups/tag.py # linode_api4/objects/networking.py # test/unit/groups/networking_test.py

TPT-4278: python-sdk: Implement support for Reserved IP for IPv4

1c63131

Create int tests for Reserved IPs networking endpoints

ccd3020

mawilk90 added 20 commits May 12, 2026 15:15

Create int tests for Reserved IPs: types, allocate

799f113

Create int tests for Reserved IPs: ephemeral

3d70ecc

Create int tests for Reserved IPs: linode instances

7da867a

Move fixtures for reserved IPs into conftest

6ee4d06

Create int tests for Reserved IPs: linode interfaces

5a98989

Create int tests for Reserved IPs: nodebalancers

a56bf1e

Create int tests for Reserved IPs: tags

3f0838a

Refactor

3930e05

Update tests after API changes on DevCloud

f24e2af

Create int tests for Reserved IPs: tags linode#2

f058877

Linter fix

bb5fabe

Linter fix

09bf1d0

Remove pytest.ini

6a6afc9

Remove unused assertions after API Team clarifications

5d57dc1

Use reservedIP's region for NB

f88bff4

Refactor

155d377

Address Copilot remarks

42bd110

Linter fix

2a630ae

Revert capabilities' changes in get_regions

b52e666

Linter fixes

b9ca4cf

mawilk90 force-pushed the feature/TPT-4285-python-sdk-implement-integration-tests-for-reserved-ip-for-ipv4 branch from 4b0f363 to b9ca4cf Compare May 12, 2026 13:19

Merge branch 'proj/reserved-ips' into feature/TPT-4285-python-sdk-imp…

9e68fea

…lement-integration-tests-for-reserved-ip-for-ipv4

mawilk90 requested review from psnoch-akamai and removed request for ckulinsk May 13, 2026 13:03

zliang-akamai requested a review from Copilot May 18, 2026 23:41

Copilot started reviewing on behalf of zliang-akamai May 18, 2026 23:41 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

psnoch-akamai reviewed May 21, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TPT-4285: Implement integration tests for ReservedIP for IPv4#688

TPT-4285: Implement integration tests for ReservedIP for IPv4#688
mawilk90 wants to merge 27 commits into
linode:proj/reserved-ipsfrom
mawilk90:feature/TPT-4285-python-sdk-implement-integration-tests-for-reserved-ip-for-ipv4

mawilk90 commented Apr 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

psnoch-akamai May 21, 2026

Uh oh!

psnoch-akamai May 21, 2026

Uh oh!

psnoch-akamai May 21, 2026

Uh oh!

psnoch-akamai May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	assert reserved_ip.tags == tags if tags else reserved_ip.tags == []
	assert reserved_ip.tags == expected_tags

Conversation

mawilk90 commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

✔️ How to Test

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

psnoch-akamai May 21, 2026

Choose a reason for hiding this comment

Uh oh!

psnoch-akamai May 21, 2026

Choose a reason for hiding this comment

Uh oh!

psnoch-akamai May 21, 2026

Choose a reason for hiding this comment

Uh oh!

psnoch-akamai May 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mawilk90 commented Apr 27, 2026 •

edited

Loading